mirror of
https://github.com/NoiTheCat/BirthdayBot.git
synced 2024-11-24 17:34:13 +00:00
Improve performance by placing updates in transaction
This commit is contained in:
parent
51e241aca8
commit
3741222c68
1 changed files with 24 additions and 20 deletions
|
@ -61,6 +61,7 @@ class DataRetention : BackgroundService {
|
|||
// Do actual updates
|
||||
int updatedGuilds = 0;
|
||||
int updatedUsers = 0;
|
||||
using (var tUpdate = db.BeginTransaction()) {
|
||||
foreach (var item in updateList) {
|
||||
var guild = item.Key;
|
||||
var userlist = item.Value;
|
||||
|
@ -74,13 +75,15 @@ class DataRetention : BackgroundService {
|
|||
updatedUsers += await cUpdateGuildUser.ExecuteNonQueryAsync(CancellationToken.None).ConfigureAwait(false);
|
||||
}
|
||||
}
|
||||
await tUpdate.CommitAsync(CancellationToken.None).ConfigureAwait(false);
|
||||
}
|
||||
var resultText = new StringBuilder();
|
||||
resultText.Append($"Updated {updatedGuilds} guilds, {updatedUsers} users.");
|
||||
|
||||
// Deletes both guild and user data if it hasn't been seen for over the threshold defined at the top of this file
|
||||
// Expects referencing tables to have 'on delete cascade'
|
||||
using var t = db.BeginTransaction();
|
||||
int staleGuilds, staleUsers;
|
||||
using (var tRemove = db.BeginTransaction()) {
|
||||
using (var c = db.CreateCommand()) {
|
||||
c.CommandText = $"delete from {GuildConfiguration.BackingTable}" +
|
||||
$" where (now() - interval '{StaleGuildThreshold} days') > last_seen";
|
||||
|
@ -91,6 +94,8 @@ class DataRetention : BackgroundService {
|
|||
$" where (now() - interval '{StaleUserThreashold} days') > last_seen";
|
||||
staleUsers = await c.ExecuteNonQueryAsync(CancellationToken.None).ConfigureAwait(false);
|
||||
}
|
||||
await tRemove.CommitAsync(CancellationToken.None).ConfigureAwait(false);
|
||||
}
|
||||
if (staleGuilds != 0 || staleUsers != 0) {
|
||||
resultText.Append(" Discarded ");
|
||||
if (staleGuilds != 0) {
|
||||
|
@ -102,7 +107,6 @@ class DataRetention : BackgroundService {
|
|||
}
|
||||
resultText.Append('.');
|
||||
}
|
||||
t.Commit();
|
||||
Log(resultText.ToString());
|
||||
} finally {
|
||||
_updateLock.Release();
|
||||
|
|
Loading…
Reference in a new issue