Noi/BirthdayBot
1
0
Fork 0
mirror of https://github.com/NoiTheCat/BirthdayBot.git synced 2024-11-24 17:34:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unneeded TODOs

Browse source 
A better logging implementation is no longer planned for now, as the
current method has proven to be sufficient so far. It may even continue
to be so for a while.
This commit is contained in:
Noi 2022-08-31 21:13:41 -07:00
parent 12fe869b26
commit 854cd0626b
3 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ApplicationCommands/ModalResponder.cs
View file

@ -27,7 +27,6 @@ static class ModalResponder {
await handler(arg, channel, data).ConfigureAwait(false); await handler(arg, channel, data).ConfigureAwait(false);
} catch (Exception e) { } catch (Exception e) {
inst.Log(nameof(ModalResponder), $"Unhandled exception. {e}"); inst.Log(nameof(ModalResponder), $"Unhandled exception. {e}");
// TODO when implementing proper application error logging, see here
await arg.RespondAsync(ShardInstance.InternalError); await arg.RespondAsync(ShardInstance.InternalError);
} }
} }

2
BackgroundServices/BirthdayRoleUpdate.cs
View file

@ -111,7 +111,7 @@ class BirthdayRoleUpdate : BackgroundService {
private static async Task<IEnumerable<SocketGuildUser>> UpdateGuildBirthdayRoles(SocketGuild g, SocketRole r, HashSet<ulong> toApply) { private static async Task<IEnumerable<SocketGuildUser>> UpdateGuildBirthdayRoles(SocketGuild g, SocketRole r, HashSet<ulong> toApply) {
var additions = new List<SocketGuildUser>(); var additions = new List<SocketGuildUser>();
try { try {
var removals = new List<SocketGuildUser>(); // TODO check if roles can be removed in-place instead of building a list first var removals = new List<SocketGuildUser>();
var no_ops = new HashSet<ulong>(); var no_ops = new HashSet<ulong>();
// Scan role for members no longer needing it // Scan role for members no longer needing it

2
ShardInstance.cs
View file

@ -127,7 +127,6 @@ public sealed class ShardInstance : IDisposable {
await _interactionService.ExecuteCommandAsync(context, _services).ConfigureAwait(false); await _interactionService.ExecuteCommandAsync(context, _services).ConfigureAwait(false);
} catch (Exception e) { } catch (Exception e) {
Log(nameof(DiscordClient_InteractionCreated), $"Unhandled exception. {e}"); Log(nameof(DiscordClient_InteractionCreated), $"Unhandled exception. {e}");
// TODO when implementing proper application error logging, see here
if (arg.Type == InteractionType.ApplicationCommand) { if (arg.Type == InteractionType.ApplicationCommand) {
if (arg.HasResponded) await arg.ModifyOriginalResponseAsync(prop => prop.Content = InternalError); if (arg.HasResponded) await arg.ModifyOriginalResponseAsync(prop => prop.Content = InternalError);
else await arg.RespondAsync(InternalError); else await arg.RespondAsync(InternalError);
@ -161,7 +160,6 @@ public sealed class ShardInstance : IDisposable {
await context.Interaction.RespondAsync(errReply, ephemeral: true).ConfigureAwait(false); await context.Interaction.RespondAsync(errReply, ephemeral: true).ConfigureAwait(false);
} else { } else {
// Generic error response // Generic error response
// TODO when implementing proper application error logging, see here
var ia = context.Interaction; var ia = context.Interaction;
if (ia.HasResponded) await ia.ModifyOriginalResponseAsync(p => p.Content = InternalError).ConfigureAwait(false); if (ia.HasResponded) await ia.ModifyOriginalResponseAsync(p => p.Content = InternalError).ConfigureAwait(false);
else await ia.RespondAsync(InternalError).ConfigureAwait(false); else await ia.RespondAsync(InternalError).ConfigureAwait(false);