Noi/RegexBot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix race condition between sending notification and removing from server

Browse source
This commit is contained in:
Noikoio 2018-03-14 23:59:24 -07:00
parent 18cd562993
commit 6127bb2ee7
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Module/ModCommands/Commands/BanKick.cs
View file

@ -132,6 +132,7 @@ namespace Noikoio.RegexBot.Module.ModCommands.Commands
string reasonlog = $"Invoked by {msg.Author.ToString()}."; string reasonlog = $"Invoked by {msg.Author.ToString()}.";
if (reason != null) reasonlog += $" Reason: {reason}"; if (reason != null) reasonlog += $" Reason: {reason}";
reasonlog = Uri.EscapeDataString(reasonlog); reasonlog = Uri.EscapeDataString(reasonlog);
await notifyTask;
#warning Remove EscapeDataString call on next Discord.Net update #warning Remove EscapeDataString call on next Discord.Net update
#if !DEBUG #if !DEBUG
if (_mode == CommandMode.Ban) await g.AddBanAsync(targetId, _purgeDays, reasonlog); if (_mode == CommandMode.Ban) await g.AddBanAsync(targetId, _purgeDays, reasonlog);
@ -140,7 +141,7 @@ namespace Noikoio.RegexBot.Module.ModCommands.Commands
#warning "Actual kick/ban action is DISABLED during debug." #warning "Actual kick/ban action is DISABLED during debug."
#endif #endif
string resultmsg = BuildSuccessMessage(targetdisp); string resultmsg = BuildSuccessMessage(targetdisp);
if (await notifyTask == false) resultmsg += NotifyFailed; if (notifyTask.Result == false) resultmsg += NotifyFailed;
await msg.Channel.SendMessageAsync(resultmsg); await msg.Channel.SendMessageAsync(resultmsg);
} }
catch (Discord.Net.HttpException ex) catch (Discord.Net.HttpException ex)